ref: drop withOrganizations HoC#115321
Merged
evanpurkhiser merged 1 commit intoMay 11, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-drop-withorganizations-hoc
branch
from
6ff3340 to
3914503
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3914503. Configure here.
Replace the last two consumers (notificationSettings and its controller) with useLegacyStore(OrganizationsStore) and delete the HoC. Both consumers were already function components, so no wrapper was needed.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-drop-withorganizations-hoc
branch
from
3914503 to
d2b6963
Compare
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.47% |
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
Replace the last two consumers (`notificationSettings` and its controller) with `useLegacyStore(OrganizationsStore)` and delete the HoC. Both consumers were already function components, so no wrapper was needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the last two consumers (
notificationSettingsand its controller) withuseLegacyStore(OrganizationsStore)and delete the HoC. Both consumers were already function components, so no wrapper was needed.Part of an ongoing cleanup of legacy
withXHoCs instatic/app/utils/.