feat(dashboards): Repair MCP dashboard widget filters#115543
Open
gggritso wants to merge 2 commits into
Open
Conversation
Replace `span.name:mcp.server` with `span.op:mcp.server` in every DashboardWidgetQuery.conditions value. A recent Relay change corrected the `name` of MCP spans, breaking the old filter. The prebuilt configs were already fixed in code, but widgets persisted from copies or hand- edited filters still carry the broken substring. Post-deployment, idempotent, scans only rows that contain the old substring. Refs DAIN-1673 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
gggritso
changed the title
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
Add a TestMigrations case that covers the substring replacement: bare match, match alongside `has:` clauses, match embedded in a longer condition, rows already using `span.op:`, and unrelated rows. Refs DAIN-1673 Co-Authored-By: Claude <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
gggritso
added a commit
that referenced
this pull request
May 14, 2026
…5540) getsentry/relay#5961 correctly (but unexpectedly) changed the `name` attribute for MCP spans, which caused our pre-built dashboards to stop loading data, because the `span.name:mcp.server` filter is no longer valid. Instead, we need to use `span.op` which is less semantic but is actually correct! I also have a migration to repair existing widgets, there are only ~100: #115543 References [DAIN-1673](https://linear.app/getsentry/issue/DAIN-1673/mcp-pre-built-dashboards-use-incorrect-filters). Co-authored-by: Claude <noreply@anthropic.com>
wedamija
approved these changes
May 14, 2026
Comment on lines
+33
to
+35
| queryset = DashboardWidgetQuery.objects.filter(conditions__contains=_OLD_FILTER).only( | ||
| "id", "conditions" | ||
| ) |
Member
There was a problem hiding this comment.
I think this query will run fast enough to not time out, since the table is only 1.2m rows
Comment on lines
+33
to
+35
| queryset = DashboardWidgetQuery.objects.filter(conditions__contains=_OLD_FILTER).only( | ||
| "id", "conditions" | ||
| ) |
Member
There was a problem hiding this comment.
I'd recommend .values_list instead of .only to just fetch the values you need.
| queryset = DashboardWidgetQuery.objects.filter(conditions__contains=_OLD_FILTER).only( | ||
| "id", "conditions" | ||
| ) | ||
| for row in RangeQuerySetWrapperWithProgressBarApprox(queryset): |
Member
There was a problem hiding this comment.
RangeQuerySetWrapperWithProgressBarApprox only works when you want to iterate the whole table. You don't really need to use this at all if you're querying only 100ish rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A consequence of getsentry/relay#5961 is that
span.nameof MCP server spans went from"mcp.server"(incorrect) to actual names like"tool/call whatever". Any conditions like"span.name:mcp.server"will now always be false. Unfortunately this breaks any dashboards that were cloned from our pre-built ones. This adds a migration to repair people's dashboards.span.opis correctly"mcp.server"so that condition is safe, and equivalent to the previous one. The prebuilt configs were fixed in #115540.There are ~100 of these widgets, so it's a fast migration.
References DAIN-1673.