fix(replays): make link copy button accessible and non-variable width#115598
Conversation
| height: 34px; | ||
| `; | ||
|
|
||
| const HoverArea = styled(Flex)``; |
There was a problem hiding this comment.
[Question] Do we, have a better way of doing this? Note the need to ${HoverArea} a few lines later.
There was a problem hiding this comment.
I wonder if this is a legacy button setup before scraps 🤔
Wonder if we could use something like a transparent button here?
Tho maybe i'm not fully understanding why we're overriding the opacity like this.
There was a problem hiding this comment.
This is a transparent button variant already :c
I'll ask in design-engineering, agreed it does feel kind of legacy/spooky...
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
| height: 34px; | ||
| `; | ||
|
|
||
| const HoverArea = styled(Flex)``; |
There was a problem hiding this comment.
I wonder if this is a legacy button setup before scraps 🤔
Wonder if we could use something like a transparent button here?
Tho maybe i'm not fully understanding why we're overriding the opacity like this.
|
Fixed REPLAY-916 for now. I have the ask out in design-eng about copy and will probably do a followup cleanup. |
Fixes two issues with the replay link copy button:
focus-withinfor its hover presence so non-mouse (e.g. keyboard) users can see itAlso removes an extra
<Flex>container around the flex container.