ref(ui): migrate ad-hoc hover-reveal patterns to RevealOnHover#115955
Draft
natemoo-re wants to merge 11 commits into
Draft
ref(ui): migrate ad-hoc hover-reveal patterns to RevealOnHover#115955natemoo-re wants to merge 11 commits into
natemoo-re wants to merge 11 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration batches on top of #115953. Replaces ad-hoc hover-reveal across three categories:
Flex-wrapper migrations (simple swap):
replayDetailsPageBreadcrumbs— removes theconst HoverArea = styled(Flex)``;empty-styled-component hack from #115598.issueIdBreadcrumb— eliminatesuseState+onMouseEnter/onMouseLeave. Was keyboard-inaccessible.replayTagsTableRow+releaseDropdownFilter— removes.invisible-buttonclassName convention.Callback-children migrations (grid rows):
eventTagsTreeRow— CSS Grid subgrid row. RemovesisVisibleuseState +onOpenChange—:focus-withinhandles the "keep dropdown visible while open" case.attributesTree— identical pattern.flagDetailsDrawerContent— grid subgrid row with.invisible+isVisiblestate.tagDetailsDrawerContent— same pattern.eventFeatureFlagSection+flagActionDropdown— gridValueWrapperwith nested.invisible .flag-buttonselector.All 11 files gain
:focus-withinsupport and@media (hover: hover)touch device handling they didn't have before.Depends on #115953.