ref(metrics): Split metric attribute tree actions#115641
Merged
nsdeschenes merged 3 commits intoMay 19, 2026
Merged
Conversation
Give metric details their own attribute tree actions hook so the menu only exposes metric-supported filter actions. This removes the logs table column action from metrics while reusing the shared query filter helper. Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
JoshuaKGoldberg
approved these changes
May 18, 2026
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Yup. ✅
Thinking out loud: my instinct was that these two hooks might have shared logic to extract & reuse somewhere. But I don't think that's the case.
nsdeschenes
deleted the
nd/ref-explore-create-metrics-specific-actions-hook
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some work to split up metric detail panel actions into their own hook, to disconnect them from logs. We've also removed the ability to adding attribute to column, as that's not something that is supported by metrics samples table at this time.