ref(preprod): Remove deprecated comparison_run_info and approval_info from snapshot detail API#115652
Merged
mtopo27 merged 1 commit intoMay 15, 2026
Conversation
… from snapshot detail API The flat fields (comparison_state, approval_status, comparison_error_message, approvers) added in #115604 fully replace the nested comparison_run_info and approval_info objects. The frontend migrated to the flat fields in #115633. Remove the SnapshotComparisonRunInfo and SnapshotApprovalInfo Pydantic classes, their fields on SnapshotDetailsApiResponse, and the endpoint code that assembled them. The approver-building loop and derive_snapshot_status() call are kept since they feed the flat approvers and status fields. comparison_type is intentionally kept — the frontend still uses it for the diff view toggle and analytics. Refs EME-1149
github-actions
Bot
added
the
Scope: Backend
NicoHinderling
approved these changes
May 15, 2026
mtopo27
added a commit
that referenced
this pull request
May 15, 2026
…ebug modal Remove SnapshotComparisonRunInfo and SnapshotApprovalInfo interfaces and their fields from SnapshotDetailsApiResponse, matching the backend removal in #115652. Replace comparison_run_info with comparison_state in the debug modal's visible fields. Refs EME-1145
mtopo27
added a commit
that referenced
this pull request
May 15, 2026
…ebug modal (#115653) Remove the `SnapshotComparisonRunInfo` and `SnapshotApprovalInfo` TypeScript interfaces and their fields from `SnapshotDetailsApiResponse`, matching the backend removal in #115652. The debug modal now shows `comparison_state` instead of `comparison_run_info`. Depends on #115652. Refs EME-1145
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flat fields (
comparison_state,approval_status,comparison_error_message,approvers) added in #115604 fully replace the nestedcomparison_run_infoandapproval_infoobjects. The frontend migrated to the flat fields in #115633. This removes the dead nested fields and the code that built them.Removed from the API response
SnapshotComparisonRunInfo(state, completed_at, duration_ms) andSnapshotApprovalInfo(status, approvers, is_auto_approved) Pydantic classes are deleted along with their fields onSnapshotDetailsApiResponse. The endpoint code that assembled these objects is removed. The approver-building loop andderive_snapshot_status()call are kept — they feed the flatapproversand status fields.comparison_typeis intentionally kept — the frontend still uses it for the diff view toggle and analytics.Refs EME-1149