ref(preprod): Remove deprecated snapshot detail TS types and update debug modal#115653
Conversation
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b01c2b. Configure here.
| 'app_id', | ||
| 'base_artifact_id', | ||
| 'comparison_run_info', | ||
| 'comparison_type', |
There was a problem hiding this comment.
Accidentally removed comparison_type from debug modal visible fields
Medium Severity
comparison_type was accidentally removed from VISIBLE_FIELDS alongside comparison_run_info. The PR description states the intent was to replace only comparison_run_info with comparison_state, but because the two lines were adjacent, comparison_type got swept up in the deletion. comparison_type is still a valid, non-deprecated field on SnapshotDetailsApiResponse and is actively used elsewhere, so the debug modal now silently omits it.
Reviewed by Cursor Bugbot for commit 5b01c2b. Configure here.
…ebug modal Remove SnapshotComparisonRunInfo and SnapshotApprovalInfo interfaces and their fields from SnapshotDetailsApiResponse, matching the backend removal in #115652. Replace comparison_run_info with comparison_state in the debug modal's visible fields. Refs EME-1145
comparison_state already covers the same information. No need to show the redundant comparison_type in the build metadata panel.
mtopo27
force-pushed
the
maxtopolsky/eme-1145-remove-deprecated-detail-types
branch
from
5b01c2b to
182e15e
Compare
2 participants
Remove the
SnapshotComparisonRunInfoandSnapshotApprovalInfoTypeScript interfaces and their fields fromSnapshotDetailsApiResponse, matching the backend removal in #115652. The debug modal now showscomparison_stateinstead ofcomparison_run_info.Depends on #115652.
Refs EME-1145