ref(eslint): enable no-unsafe-return for scraps#115722
Merged
Merged
Conversation
Collaborator
Author
|
bugbot run |
github-actions
Bot
added
the
Scope: Frontend
TkDodo
commented
May 18, 2026
| showTrailingItems={!!trailingItems} | ||
| > | ||
| {Array.isArray(expand) ? expand.map(item => item) : expand} | ||
| {expand} |
Collaborator
Author
There was a problem hiding this comment.
this was a no-op: React can render arrays just fine as children
Comment on lines
+324
to
325
| // eslint-disable-next-line @typescript-eslint/no-unsafe-return | ||
| () => [...collection].map(({key, props: itemProps}) => ({key, ...itemProps})), |
Collaborator
Author
There was a problem hiding this comment.
sadly, useCollection just returns any for collection.props :/
Contributor
📊 Type Coverage Diff
🔍 4 new type safety issues introduced
Type assertions (
This is informational only and does not block the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 14eed8e. Configure here.
JonasBa
approved these changes
May 18, 2026
Comment on lines
+533
to
+535
| ref: el => { | ||
| triggerRef.current = el; | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| ref: el => { | |
| triggerRef.current = el; | |
| }, | |
| ref: el => void (triggerRef.current = el), |
not really suggesting this, but you can tell typescript to ignore the return type with void
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.