fix(repositories): Fix deletion ordering for ProjectRepository children#115739
Merged
Conversation
BulkModelDeletionTask does raw SQL DELETE which bypasses Django CASCADE. SeerProjectRepositoryBranchOverride has a FK to SeerProjectRepository, which has a FK to ProjectRepository. When deleting projects or repos, the branch overrides must be deleted first, then SPR, then ProjectRepository — otherwise we get IntegrityError from the FK constraints. Fixes SENTRY-5PSY Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
evanpurkhiser
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SeerProjectRepositoryBranchOverrideto deletion child relations in project, repository, and project-repository deletion tasksSeerProjectRepository, which is deleted beforeProjectRepositoryBulkModelDeletionTaskdoes raw SQL DELETE which bypasses Django CASCADE, so FK children must be explicitly deleted in the correct orderTest plan
tests/sentry/deletions/test_project.py— all passtests/sentry/deletions/test_repository.py— all passtests/sentry/tasks/test_repository.py— all passFixes SENTRY-5PSY