lint: enable jest/prefer-jest-mocked#115791
Merged
evanpurkhiser merged 1 commit intoMay 19, 2026
Merged
Conversation
evanpurkhiser
requested review from
JoshuaKGoldberg,
natemoo-re and
scttcper
and removed request for
a team
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
JoshuaKGoldberg
approved these changes
May 19, 2026
| @@ -0,0 +1,48 @@ | |||
| import {ESLintUtils} from '@typescript-eslint/utils'; | |||
|
|
|||
| export const noJestMockCast = ESLintUtils.RuleCreator.withoutDocs({ | |||
Member
There was a problem hiding this comment.
Apologies for being a stickler, but in lint-land terminology a "cast" is a wholly different thing (runtime). Assertions are the type system feature. They're not technically interchangeable terms (even though everyone generally does in casual speak).
Suggested change
| export const noJestMockCast = ESLintUtils.RuleCreator.withoutDocs({ | |
| export const noJestMockAssertion = ESLintUtils.RuleCreator.withoutDocs({ |
| schema: [], | ||
| messages: { | ||
| noJestMockCast: | ||
| 'Use `jest.mocked({{expression}})` instead of casting with `as jest.Mock`.', |
Member
There was a problem hiding this comment.
Suggested change
| 'Use `jest.mocked({{expression}})` instead of casting with `as jest.Mock`.', | |
| 'Use `jest.mocked({{expression}})` instead of asserting with `as jest.Mock`.', |
evanpurkhiser
force-pushed
the
evanpurkhiser/lint-add-no-jest-mock-cast-rule-to-replace-as-jest-mock-with-jest-mocked-
branch
from
cd2dd54 to
ed67da5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed67da5. Configure here.
evanpurkhiser
force-pushed
the
evanpurkhiser/lint-add-no-jest-mock-cast-rule-to-replace-as-jest-mock-with-jest-mocked-
branch
from
ed67da5 to
b39419a
Compare
Member
Author
|
@JoshuaKGoldberg will update the terminology before merging this! |
Member
Author
|
Let me see if we can just use |
….mocked()` Enables jest/prefer-jest-mocked from eslint-plugin-jest, which covers `jest.Mock`, `jest.MockedFunction`, `jest.MockedClass`, and `jest.MockedObject` assertions and includes an autofix to jest.mocked().
evanpurkhiser
force-pushed
the
evanpurkhiser/lint-add-no-jest-mock-cast-rule-to-replace-as-jest-mock-with-jest-mocked-
branch
from
b39419a to
cb500e2
Compare
evanpurkhiser
changed the title
as jest.Mock with jest.mocked()
evanpurkhiser
deleted the
evanpurkhiser/lint-add-no-jest-mock-cast-rule-to-replace-as-jest-mock-with-jest-mocked-
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
jest/prefer-jest-mockedfromeslint-plugin-jest(already a dep). It coversjest.Mock,jest.MockedFunction,jest.MockedClass, andjest.MockedObjectassertions and autofixes tojest.mocked(). The five remaining offending files are fixed in this PR as well.