ref(hookStore): Change HookStore to single-value semantics#115796
Merged
evanpurkhiser merged 2 commits intoMay 19, 2026
Merged
Conversation
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
Type assertions (
This is informational only and does not block the PR. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0bd87e0. Configure here.
HookStore.get() previously returned an array of registered callbacks, but in practice only a single callback was ever registered per hook name. The registration pattern (object literal keys in GETSENTRY_HOOKS, and the remove-then-add pattern in GSBillingNavigationConfig) already guaranteed at most one callback per slot. Tighten the types to reflect reality: - get() returns Hooks[H] | undefined instead of Array<Hooks[H]> - add() is renamed to set() and overwrites instead of pushing - remove() no longer takes a callback argument — it just clears the slot All consumers updated: [0] indexing gone, .forEach/.map loops replaced with single optional calls.
0bd87e0 to
1dd58cd
Compare
scttcper
approved these changes
May 19, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

HookStore.get() previously returned an array of registered callbacks,
but in practice only a single callback was ever registered per hook
name. The registration pattern (object literal keys in GETSENTRY_HOOKS,
and the remove-then-add pattern in GSBillingNavigationConfig) already
guaranteed at most one callback per slot.
Tighten the types to reflect reality:
All consumers updated: [0] indexing gone, .forEach/.map loops replaced
with single optional calls.