ref(hooks): Replace HookStore with a plain hook registry

[evanpurkhiser]

Introduce static/app/hookRegistry.tsx — a simple Map-backed registry with registerHook() and getHook() exports — and delete hookStore.tsx entirely.

What changed:

• HookStore.get() / HookStore.set() → getHook() / registerHook() across all call sites
• Hook and HookOrDefault components simplified to plain render-time reads — no useState, no useEffect, no Reflux listen
• HookStore.persistCallback / getCallback replaced by a plain module-level cell in setOrganizationCallback.tsx
• hookStore.tsx deleted; HookStore removed from the SentryApp browser globals
• All test files updated to use registerHook / getHook; HookStore.init() cleanup calls removed

[github-actions]

📊 Type Coverage Diff

Metric	Before	After	Delta
Coverage	93.56%	93.56%	±0%
Typed	135,547	135,521	🔴 -26
Untyped	9,334	9,335	🔴 +1

🔍 2 new type safety issues introduced

any-typed symbols (1 new)

File	Line	Detail
static/app/hookRegistry.tsx	12	registry (var)

Type assertions (as) (1 new)

File	Line	Detail
static/app/hookRegistry.tsx	26	`as Hooks[H]

This is informational only and does not block the PR.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74c586c. Configure here.}

[cursor]

Missing registry cleanup causes test order dependency

Low Severity

The beforeEach(() => { HookStore.init(); }) cleanup was removed, but hookRegistry.tsx exposes no way to clear or remove registered hooks. The first test ("should render default") relies on component:replay-onboarding-cta not being registered, while the second test registers it. Since the module-level Map persists across tests within a file, any reordering (or future test insertion) that places a registerHook call before this test will cause it to fail. A clearHooks() (or per-key removeHook()) export is needed for test isolation.

Additional Locations (1)

• static/app/hookRegistry.tsx#L11-L27

 

^{Reviewed by Cursor Bugbot for commit 74c586c. Configure here.}