ref(repositories): Simplify ProjectRepoLink serializer and make url better#115826
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
evanpurkhiser
approved these changes
May 19, 2026
github-actions
Bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
wedamija
force-pushed
the
danf/fix-repo-link-serializer
branch
from
919f89c to
1b6cc86
Compare
Use validated_data["repositoryId"] in create() instead of storing self.repository as side-effect state during validation. The existence check uses .exists() instead of .get() since we only need the ID. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
wedamija
force-pushed
the
danf/fix-repo-link-serializer
branch
from
1b6cc86 to
40d99f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use validated_data["repositoryId"] in create() instead of storing self.repository as side-effect state during validation. The existence check uses .exists() instead of .get() since we only need the ID.
Also updates the url of the api to remove the
-link