ref(alerts): migrate issue rule editor off browserHistory#115924
Merged
evanpurkhiser merged 1 commit intoMay 20, 2026
Merged
Conversation
Replace the `browserHistory.replace` call in `IssueRuleEditor` with a navigate prop supplied by a function wrapper that calls `useNavigate()`.
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d5aa222. Configure here.
| stepBack: -2, | ||
| }) | ||
| }), | ||
| {replace: true} |
Contributor
There was a problem hiding this comment.
Missing scroll reset on delete
Low Severity
After a successful delete, this.props.navigate is called with only {replace: true}. The removed browserHistory.replace shim also set preventScrollReset: true to match react-router 3, so post-delete navigation may scroll the rules list to the top unexpectedly.
Reviewed by Cursor Bugbot for commit d5aa222. Configure here.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
scttcper
approved these changes
May 20, 2026
evanpurkhiser
deleted the
evanpurkhiser/ref-alerts-migrate-issue-rule-editor-off-browserhistory
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
Replace the `browserHistory.replace` call in `IssueRuleEditor` with a navigate prop supplied by a function wrapper that calls `useNavigate()`.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
browserHistory.replacecall inIssueRuleEditorwith a navigate prop supplied by a function wrapper that callsuseNavigate().