ref(trace): migrate virtualizedViewManager off browserHistory#115927
Conversation
Add a public `navigate` field on `VirtualizedViewManager` and assign it from `useTraceWaterfallModels` (which calls `useNavigate()`). The FOV query param sync now goes through it instead of the deprecated `browserHistory` shim. The field is nullable so existing test constructors don't have to pass anything.
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0fe4878. Configure here.
| }, | ||
| }); | ||
| {replace: true} | ||
| ); |
There was a problem hiding this comment.
Missing preventScrollReset on FOV replace navigation
Low Severity
The old browserHistory.replace() shim automatically passed preventScrollReset: true (see comment in browserHistory.tsx L76-78). The new navigate() call only passes {replace: true}, losing scroll-reset prevention. Since this fires on every debounced FOV change during panning/zooming, it may cause unwanted scroll jumps. Consider adding preventScrollReset: true to the options.
Reviewed by Cursor Bugbot for commit 0fe4878. Configure here.
evanpurkhiser
deleted the
evanpurkhiser/ref-trace-migrate-virtualizedviewmanager-off-browserhistory
branch
Add a public `navigate` field on `VirtualizedViewManager` and assign it from `useTraceWaterfallModels` (which calls `useNavigate()`). The FOV query-param sync now goes through it instead of the deprecated `browserHistory` shim. The field is nullable so existing test constructors don't have to pass anything.
2 participants
Add a public
navigatefield onVirtualizedViewManagerand assign it fromuseTraceWaterfallModels(which callsuseNavigate()). The FOV query-param sync now goes through it instead of the deprecatedbrowserHistoryshim.The field is nullable so existing test constructors don't have to pass anything.