ref(organization-create): drop dead browserHistory comment#115928
Merged
evanpurkhiser merged 1 commit intoMay 20, 2026
Merged
Conversation
Remove a stale commented-out `browserHistory.pushState` call that's been superseded by `testableWindowLocation.assign` (and which referenced a method that doesn't even exist on the current shim).
github-actions
Bot
added
the
Scope: Frontend
ryan953
approved these changes
May 20, 2026
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.57% |
evanpurkhiser
deleted the
evanpurkhiser/ref-organization-create-drop-dead-browserhistory-comment
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
Remove a stale commented-out `browserHistory.pushState` call that's been superseded by `testableWindowLocation.assign` (and which referenced a method that doesn't even exist on the current shim).
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a stale commented-out
browserHistory.pushStatecall that's been superseded bytestableWindowLocation.assign(and which referenced a method that doesn't even exist on the current shim).