Skip to content

ref(🥞): replace local z-index theme refs with bare z-index: 1#115956

Draft
natemoo-re wants to merge 6 commits into
nm/zindex/wire-portalsfrom
nm/zindex/remove-local-zindex
Draft

ref(🥞): replace local z-index theme refs with bare z-index: 1#115956
natemoo-re wants to merge 6 commits into
nm/zindex/wire-portalsfrom
nm/zindex/remove-local-zindex

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re commented May 20, 2026

Summary

  • Replace theme.zIndex.initial (1), theme.zIndex.header (1000), and theme.zIndex.truncationFullValue (10) with bare z-index: 1
  • Within a Layer stacking context, z-index: 1 is sufficient for any local override (sticky headers, hover states, truncation expansion)
  • This is the target end state: the only z-index ever used is z-index: 1

🥞 Layer Primitive Series

Test plan

  • Sticky headers in issue details, explore, settings still pin on scroll
  • Truncated text expands on hover above siblings
  • Replay player overlays (buffering, fast-forward) render correctly
  • Chart tooltips still visible (zlevel change)
  • pnpm run typecheck

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 20, 2026
@natemoo-re natemoo-re changed the base branch from master to nm/zindex/wire-portals May 20, 2026 21:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.58%

@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 0e6e40d to 579605a Compare May 21, 2026 13:59
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 82f78fa to c5f5246 Compare May 21, 2026 14:00
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from c5f5246 to 2921179 Compare May 21, 2026 14:14
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 2921179 to 9b9ce12 Compare May 21, 2026 17:31
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 9b9ce12 to 32cae40 Compare May 21, 2026 17:35
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 32cae40 to 8346b2f Compare May 21, 2026 17:42
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 255dc7c to 97da138 Compare May 26, 2026 17:16
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 8346b2f to 07c7c52 Compare May 26, 2026 17:20
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 97da138 to f0adcb8 Compare May 26, 2026 21:18
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 62b7636 to 5744874 Compare May 26, 2026 21:22
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from f0adcb8 to 1d3b325 Compare May 26, 2026 21:59
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 5744874 to 98fe28d Compare May 26, 2026 21:59
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 1d3b325 to 471b49d Compare May 26, 2026 22:26
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-local-zindex branch from 98fe28d to 7aab71d Compare May 26, 2026 22:27
natemoo-re and others added 6 commits May 28, 2026 12:44
theme.zIndex.initial, header, and truncationFullValue are replaced with
bare z-index: 1. Within a Layer stacking context, 1 is sufficient for
local overrides like sticky headers and hover states.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
File was deleted on master (refactored). Rebase conflict resolution
accidentally re-created it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant