ref(🥞): remove structural z-index references (drawer, modal, toast, sidebar)#115959
Draft
natemoo-re wants to merge 6 commits into
Draft
ref(🥞): remove structural z-index references (drawer, modal, toast, sidebar)#115959natemoo-re wants to merge 6 commits into
natemoo-re wants to merge 6 commits into
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
This was referenced May 20, 2026
0e6e40d to
579605a
Compare
9d3b3b8 to
75df6ce
Compare
75df6ce to
1b20f57
Compare
1b20f57 to
4eb0854
Compare
4eb0854 to
00b1031
Compare
00b1031 to
5b999e1
Compare
255dc7c to
97da138
Compare
f8286ba to
e37ef03
Compare
97da138 to
f0adcb8
Compare
e37ef03 to
2aef99d
Compare
f0adcb8 to
1d3b325
Compare
2aef99d to
dbca8b8
Compare
1d3b325 to
471b49d
Compare
dbca8b8 to
76d04e7
Compare
76d04e7 to
cf75d11
Compare
cf75d11 to
7af8817
Compare
7af8817 to
49a2d4e
Compare
Drawer, modal, toast, sidebar, and sidebarPanel z-index values are now redundant — Layer handles cross-surface stacking via DOM order and isolation: isolate. Internal ordering within surfaces uses z-index: 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Missed callsite — actionCreators/modal.tsx passed zIndex to backdrop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
22592f2 to
981a0b3
Compare
49a2d4e to
c766ce4
Compare
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme.zIndex.drawer,modal,toast,sidebar,sidebarPanel, andwidgetBuilderDrawerreferencesz-index: 1🥞 Layer Primitive Series
nm/zindex/layer-primitive— Layer component + hooksnm/zindex/dom-order— DOM restructuring for paint-order stackingnm/zindex/wire-portals— Wire portal consumers to Layer outletsnm/zindex/remove-structural-zindex— Remove structural z-index refs ← this PRnm/zindex/remove-portal-zindex— Remove portal z-index refsnm/zindex/remove-local-zindex— Replace local z-index refs with bare z-index: 1nm/zindex/deprecate-zindex— Deprecate theme.zIndex scalenm/zindex/lint-ban— Lint rule banning z-index/zIndexnm/zindex/final-cleanup— Remove theme.zIndex entirelyTest plan
pnpm run typecheck