Skip to content

ref(🥞): remove structural z-index references (drawer, modal, toast, sidebar)#115959

Draft
natemoo-re wants to merge 6 commits into
nm/zindex/wire-portalsfrom
nm/zindex/remove-structural-zindex
Draft

ref(🥞): remove structural z-index references (drawer, modal, toast, sidebar)#115959
natemoo-re wants to merge 6 commits into
nm/zindex/wire-portalsfrom
nm/zindex/remove-structural-zindex

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re commented May 20, 2026

Summary

  • Remove theme.zIndex.drawer, modal, toast, sidebar, sidebarPanel, and widgetBuilderDrawer references
  • These are now handled by Layer DOM order (stacking context isolation)
  • Internal ordering within surfaces replaced with bare z-index: 1

🥞 Layer Primitive Series

Test plan

  • Open drawer, verify it paints above content
  • Open modal, verify it paints above drawer
  • Trigger toast, verify it paints above modal
  • Verify sidebar panels stack correctly in navigation
  • pnpm run typecheck

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 20, 2026
@natemoo-re natemoo-re changed the base branch from master to nm/zindex/wire-portals May 20, 2026 22:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.58%

@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 0e6e40d to 579605a Compare May 21, 2026 13:59
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from 9d3b3b8 to 75df6ce Compare May 21, 2026 14:00
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from 75df6ce to 1b20f57 Compare May 21, 2026 14:14
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from 1b20f57 to 4eb0854 Compare May 21, 2026 17:31
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from 4eb0854 to 00b1031 Compare May 21, 2026 17:35
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from 00b1031 to 5b999e1 Compare May 21, 2026 17:42
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 255dc7c to 97da138 Compare May 26, 2026 17:16
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from f8286ba to e37ef03 Compare May 26, 2026 17:16
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 97da138 to f0adcb8 Compare May 26, 2026 21:18
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from e37ef03 to 2aef99d Compare May 26, 2026 21:22
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from f0adcb8 to 1d3b325 Compare May 26, 2026 21:59
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from 2aef99d to dbca8b8 Compare May 26, 2026 21:59
@natemoo-re natemoo-re force-pushed the nm/zindex/wire-portals branch from 1d3b325 to 471b49d Compare May 26, 2026 22:26
@natemoo-re natemoo-re force-pushed the nm/zindex/remove-structural-zindex branch from dbca8b8 to 76d04e7 Compare May 26, 2026 22:26
natemoo-re and others added 6 commits May 28, 2026 12:33
Drawer, modal, toast, sidebar, and sidebarPanel z-index values are now
redundant — Layer handles cross-surface stacking via DOM order and
isolation: isolate. Internal ordering within surfaces uses z-index: 1.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Missed callsite — actionCreators/modal.tsx passed zIndex to backdrop.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant