ref(test): Remove router return from initializeOrg#116002
Merged
evanpurkhiser merged 1 commit intoMay 21, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.60% |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-test-remove-router-return-from-initializeorg
branch
from
ea31a8f to
a3a10e5
Compare
ryan953
approved these changes
May 21, 2026
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-test-remove-router-return-from-initializeorg
branch
from
a3a10e5 to
0af3180
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0af3180. Configure here.
| * @deprecated use initialRouterConfig instead. Avoid deprecatedRouterMocks. | ||
| */ | ||
| router: initialData.router, | ||
| router, |
Contributor
There was a problem hiding this comment.
routerProps out of sync
Low Severity
initializeData still spreads initializeOrg’s routerProps, but page-filter query params are only applied on the separate RouterFixture. routerProps.location can stay at defaults while router and location carry the intended query, so code using routerProps gets the wrong location.
Reviewed by Cursor Bugbot for commit 0af3180. Configure here.
Most callers only needed router.location, which is now sourced from LocationFixture directly. Specs that needed the full router instance construct one with RouterFixture inline.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-test-remove-router-return-from-initializeorg
branch
from
0af3180 to
5f0b415
Compare
JonasBa
approved these changes
May 21, 2026
evanpurkhiser
deleted the
evanpurkhiser/ref-test-remove-router-return-from-initializeorg
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
Most callers only needed `router.location`, which is now sourced from `LocationFixture` directly. Specs that needed the full router instance construct one with `RouterFixture` inline.
natemoo-re
pushed a commit
that referenced
this pull request
May 21, 2026
Most callers only needed `router.location`, which is now sourced from `LocationFixture` directly. Specs that needed the full router instance construct one with `RouterFixture` inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most callers only needed
router.location, which is now sourced fromLocationFixturedirectly. Specs that needed the full router instance construct one withRouterFixtureinline.