fix(onboarding): Remove broken aria-label from RadioGroup radio inputs#116032
Merged
Conversation
RadioGroup was calling `.toString()` on a `React.ReactNode` to set `aria-label` on each radio input, which produced `[object Object]` for any JSX label. The wrapping `<label>` element already provides the accessible name, so the explicit `aria-label` was redundant and actively harmful. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.62% |
`RadioGroup` was calling `.toString()` on a `React.ReactNode` to set
`aria-label`, which produced `[object Object]` for any JSX label. Only
set `aria-label` when the label is actually a string, otherwise let the
wrapping `<label>` element provide the accessible name.
Switch existing tests to use `getByRole('radio')` so they actually catch
this kind of breakage.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
scttcper
changed the title
evanpurkhiser
approved these changes
May 21, 2026
natemoo-re
pushed a commit
that referenced
this pull request
May 21, 2026
#116032) `RadioGroup` was calling `.toString()` on a `React.ReactNode` to build `aria-label` for each radio input, which produced `aria-label="[object Object]"` whenever the label was JSX. The wrapping `<label>` element already provides the accessible name, so the explicit `aria-label` was redundant and actively harmful.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RadioGroupwas calling.toString()on aReact.ReactNodeto buildaria-labelfor each radio input, which producedaria-label="[object Object]"whenever the label was JSX. The wrapping<label>element already provides the accessible name, so the explicitaria-labelwas redundant and actively harmful.