ref(issueDetails): collapse ParticipantList wrapper div to a Flex#116175
Merged
evanpurkhiser merged 1 commit intoMay 26, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-issuedetails-collapse-participantlist-wrapper-div-to-a-flex
branch
from
fc17a0f to
2da1bc2
Compare
The wrapper `<div>` around the avatar trigger established an inline formatting context, reserving descender space below the inline-block Button and making the trigger render taller than the visible avatars. That extra height pushed the "participating" / "viewed" label below the visual center of the avatar row.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-issuedetails-collapse-participantlist-wrapper-div-to-a-flex
branch
from
2da1bc2 to
f2b9c6c
Compare
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
TkDodo
approved these changes
May 26, 2026
evanpurkhiser
deleted the
evanpurkhiser/ref-issuedetails-collapse-participantlist-wrapper-div-to-a-flex
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tweaks to the People section in issue details:
ParticipantListwrapper. The wrapper<div>around the avatar trigger established an inline formatting context, which reserves descender space below the inline-blockButton. That made the trigger element a few pixels taller than the visible avatars, pushing the "participating" / "viewed" label below the visual center of the avatar row. Swapping the wrapper to a<Flex>removes the inline formatting context, so the trigger collapses to the Button's actual height and the labels sit vertically centered with the avatars.Row spacing. The participating and viewed rows were rendered as bare siblings with no spacing between them. Wrapped them in a
Flex direction="column"with a gap so they get a bit of breathing room.