Skip to content

fix(issues): Align collapsed activity row#116266

Merged
scttcper merged 2 commits into
masterfrom
scttcper/issue-sidebar-activity
May 27, 2026
Merged

fix(issues): Align collapsed activity row#116266
scttcper merged 2 commits into
masterfrom
scttcper/issue-sidebar-activity

Conversation

@scttcper
Copy link
Copy Markdown
Member

instead of attempting to overrides the styles of a timeline item render a custom timeline component. It was never really a timeline item. Adds missing error boundary to sidebar.

before

image

after

image

The sidebar activity collapse link was pretending to be a full timeline item, which made the v2 marker column push the ellipsis and button out of place.

Render a small dedicated row for the collapsed activity affordance so the dots sit on the timeline line and the button starts in the next column. Also wrap the sidebar activity section in a mini error boundary so activity failures do not take down the rest of the sidebar.

Co-Authored-By: Codex GPT-5 <noreply@openai.com>
@scttcper scttcper requested a review from a team as a code owner May 26, 2026 23:39
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 26, 2026
@scttcper scttcper requested a review from a team May 26, 2026 23:39
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f21b418. Configure here.

icon={<RotatedEllipsisIcon direction="up" />}
/>
</Container>
</MoreActivityRow>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapsed row ignores v2 grid

Medium Severity

For orgs with issue-activity-feed-v2, activity rows use a marker plus icon column, but MoreActivityRow is only a 22px column and link. The removed ActivityTimelineItem marker kept the “View more” control aligned with titles; the custom row shifts the link left relative to other entries.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f21b418. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i want to ignore grid

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.58%

Comment thread static/app/views/issueDetails/activitySection/index.tsx Outdated
@scttcper scttcper enabled auto-merge (squash) May 27, 2026 00:11
@scttcper scttcper merged commit 7417a7c into master May 27, 2026
74 checks passed
@scttcper scttcper deleted the scttcper/issue-sidebar-activity branch May 27, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants