fix(theme): Update config.theme when mutating user theme option#116336
Merged
Conversation
The command palette's theme switching uses useMutateUserOptions, which optimistically updates config.user.options.theme but never updates the derived config.theme field. ThemeAndStyleProvider reads config.theme to select the theme object, so the first dark-to-light switch after page load renders with stale tokens until useColorscheme's useEffect catches up a frame later. Set config.theme directly in onMutate for non-system theme changes, matching the pattern already used by updateUser in account.tsx. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
evanpurkhiser
approved these changes
May 27, 2026
scttcper
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command palette's theme switching uses
useMutateUserOptions, which optimistically updatesconfig.user.options.themebut never updates the derivedconfig.themefield thatThemeAndStyleProviderreads. On the first dark→light switch after page load, the theme object stays stale untiluseColorscheme'suseEffectcatches up a frame later, causing some tokens to not update.Set
config.themedirectly inonMutatefor non-system theme changes, matching the pattern already used byupdateUserinactionCreators/account.tsx.fixes DE-1266