Skip to content

fix(forms): Surface backend error messages in AutoSaveForm#116448

Merged
malwilley merged 2 commits into
masterfrom
malwilley/vercel-integration-error-messages
May 29, 2026
Merged

fix(forms): Surface backend error messages in AutoSaveForm#116448
malwilley merged 2 commits into
masterfrom
malwilley/vercel-integration-error-messages

Conversation

@malwilley
Copy link
Copy Markdown
Member

@malwilley malwilley commented May 28, 2026

Ref ISWF-2677

When AutoSaveForm gets back an error response that doesn't contain field-level errors (e.g. {detail: "Cannot override environment variable EXAMPLE"} instead of {project_mappings: ["error"]}), it currently falls back to a generic "Failed to save" message. This PR attempts to extract any detail errors before falling back.

This change, combined with #116447, should properly surface specific integration configuration errors to the user.

When an API request fails and the error response doesn't contain
field-level errors, extract the message from the response detail
instead of showing a generic "Failed to save" message.
@malwilley malwilley requested a review from a team as a code owner May 28, 2026 22:32
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 28, 2026

ISWF-2677

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 28, 2026
@malwilley malwilley requested a review from a team May 28, 2026 22:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.59%

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e391ee7. Configure here.

Comment thread static/app/components/core/form/autoSaveForm.tsx Outdated
@malwilley malwilley merged commit 0451988 into master May 29, 2026
76 checks passed
@malwilley malwilley deleted the malwilley/vercel-integration-error-messages branch May 29, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants