Skip to content

ref(bitbucket-server): Remove legacy pipeline setup views #116489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpurkhiser merged 1 commit into from
May 29, 2026
+1 −552
Merged

ref(bitbucket-server): Remove legacy pipeline setup views #116489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 1 addition & 163 deletions src/sentry/integrations/bitbucket_server/integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@

from cryptography.hazmat.backends import default_backend
from cryptography.hazmat.primitives.serialization import load_pem_private_key
from django import forms
from django.core.validators import URLValidator
from django.http import HttpResponseRedirect
from django.http.request import HttpRequest
from django.http.response import HttpResponseBase
from django.utils.decorators import method_decorator
from django.utils.translation import gettext_lazy as _
from django.views.decorators.csrf import csrf_exempt
from rest_framework import serializers
from rest_framework.fields import BooleanField, CharField, URLField

Expand Down Expand Up @@ -47,7 +41,6 @@
from sentry.pipeline.views.base import ApiPipelineSteps, PipelineView
from sentry.shared_integrations.exceptions import ApiError, IntegrationError
from sentry.users.models.identity import Identity
from sentry.web.helpers import render_to_response

from .client import BitbucketServerClient, BitbucketServerSetupClient
from .repository import BitbucketServerRepositoryProvider
Expand Down Expand Up @@ -106,161 +99,6 @@
)


class InstallationForm(forms.Form):
url = forms.CharField(
label=_("Bitbucket URL"),
help_text=_(
"The base URL for your Bitbucket Server instance, including the host and protocol."
),
widget=forms.TextInput(attrs={"placeholder": "https://bitbucket.example.com"}),
validators=[URLValidator()],
)
verify_ssl = forms.BooleanField(
label=_("Verify SSL"),
help_text=_(
"By default, we verify SSL certificates "
"when making requests to your Bitbucket instance."
),
widget=forms.CheckboxInput(),
required=False,
initial=True,
)
consumer_key = forms.CharField(
label=_("Bitbucket Consumer Key"),
widget=forms.TextInput(attrs={"placeholder": "sentry-consumer-key"}),
)
private_key = forms.CharField(
label=_("Bitbucket Consumer Private Key"),
widget=forms.Textarea(
attrs={
"placeholder": "-----BEGIN RSA PRIVATE KEY-----\n...\n-----END RSA PRIVATE KEY-----"
}
),
)

def clean_url(self):
"""Strip off trailing / as they cause invalid URLs downstream"""
return self.cleaned_data["url"].rstrip("/")

def clean_private_key(self):
data = self.cleaned_data["private_key"]

try:
load_pem_private_key(data.encode("utf-8"), None, default_backend())
except Exception:
raise forms.ValidationError(
"Private key must be a valid SSH private key encoded in a PEM format."
)
return data

def clean_consumer_key(self):
data = self.cleaned_data["consumer_key"]
if len(data) > 200:
raise forms.ValidationError("Consumer key is limited to 200 characters.")
return data


class InstallationConfigView:
"""
Collect the OAuth client credentials from the user.
"""

def dispatch(self, request: HttpRequest, pipeline: IntegrationPipeline) -> HttpResponseBase:
if request.method == "POST":
form = InstallationForm(request.POST)
if form.is_valid():
form_data = form.cleaned_data

pipeline.bind_state("installation_data", form_data)
return pipeline.next_step()
else:
form = InstallationForm()

return render_to_response(
template="sentry/integrations/bitbucket-server-config.html",
context={"form": form},
request=request,
)


class OAuthLoginView:
"""
Start the OAuth dance by creating a request token
and redirecting the user to approve it.
"""

@method_decorator(csrf_exempt)
def dispatch(self, request: HttpRequest, pipeline: IntegrationPipeline) -> HttpResponseBase:
with IntegrationPipelineViewEvent(
IntegrationPipelineViewType.OAUTH_LOGIN,
IntegrationDomain.SOURCE_CODE_MANAGEMENT,
BitbucketServerIntegrationProvider.key,
).capture() as lifecycle:
if "oauth_token" in request.GET:
return pipeline.next_step()

config = pipeline.fetch_state("installation_data")
assert config is not None
client = BitbucketServerSetupClient(
config.get("url"),
config.get("consumer_key"),
config.get("private_key"),
config.get("verify_ssl"),
)

try:
request_token = client.get_request_token()
except ApiError as error:
lifecycle.record_failure(str(error), extra={"url": config.get("url")})
return pipeline.error(f"Could not fetch a request token from Bitbucket. {error}")

pipeline.bind_state("request_token", request_token)
if not request_token.get("oauth_token"):
lifecycle.record_failure("missing oauth_token", extra={"url": config.get("url")})
return pipeline.error("Missing oauth_token")

authorize_url = client.get_authorize_url(request_token)

return HttpResponseRedirect(authorize_url)


class OAuthCallbackView:
"""
Complete the OAuth dance by exchanging our request token
into an access token.
"""

@method_decorator(csrf_exempt)
def dispatch(self, request: HttpRequest, pipeline: IntegrationPipeline) -> HttpResponseBase:
with IntegrationPipelineViewEvent(
IntegrationPipelineViewType.OAUTH_CALLBACK,
IntegrationDomain.SOURCE_CODE_MANAGEMENT,
BitbucketServerIntegrationProvider.key,
).capture() as lifecycle:
config = pipeline.fetch_state("installation_data")
assert config is not None
client = BitbucketServerSetupClient(
config.get("url"),
config.get("consumer_key"),
config.get("private_key"),
config.get("verify_ssl"),
)

try:
access_token = client.get_access_token(
pipeline.fetch_state("request_token"), request.GET["oauth_token"]
)

pipeline.bind_state("access_token", access_token)

return pipeline.next_step()
except ApiError as error:
lifecycle.record_failure(str(error))
return pipeline.error(
f"Could not fetch an access token from Bitbucket. {str(error)}"
)


class InstallationConfigData(TypedDict):
url: str
consumer_key: str
Expand Down Expand Up @@ -544,7 +382,7 @@ class BitbucketServerIntegrationProvider(IntegrationProvider):
setup_dialog_config = {"width": 1030, "height": 1000}

def get_pipeline_views(self) -> list[PipelineView[IntegrationPipeline]]:
return [InstallationConfigView(), OAuthLoginView(), OAuthCallbackView()]
return []

def get_pipeline_api_steps(self) -> ApiPipelineSteps[IntegrationPipeline]:
return [InstallationConfigApiStep(), OAuthApiStep()]
Expand Down
57 changes: 0 additions & 57 deletions src/sentry/templates/sentry/integrations/bitbucket-server-config.html
View file
Open in desktop

This file was deleted.

Loading
Loading