Skip to content

ref(trace-waterfall): drop deprecated aliases from trace meta endpoint#116514

Merged
cvxluo merged 1 commit into
masterfrom
cvxluo/drop-deprecated-snake-case-aliases-from-trace-meta
May 29, 2026
Merged

ref(trace-waterfall): drop deprecated aliases from trace meta endpoint#116514
cvxluo merged 1 commit into
masterfrom
cvxluo/drop-deprecated-snake-case-aliases-from-trace-meta

Conversation

@cvxluo
Copy link
Copy Markdown
Contributor

@cvxluo cvxluo commented May 29, 2026

Remove deprecated fields from this endpoint from #115107. This makes publishing it a little cleaner: #116445. Frontend already only uses the non-deprecated versions.

…esponse

Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 29, 2026
@cvxluo cvxluo marked this pull request as ready for review May 29, 2026 19:27
@cvxluo cvxluo requested review from a team as code owners May 29, 2026 19:27
@cvxluo cvxluo requested a review from a team May 29, 2026 19:27
Comment on lines -47 to -54
# These are deprecated
logs: int
errors: int
performance_issues: int
span_count: int
transaction_child_count_map: SnubaData
span_count_map: dict[str, int]
uptime_checks: int # Only present when include_uptime is True
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure the fe doesn't rely on these at all?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm pretty confident, all the usages got updated here: https://github.com/getsentry/sentry/pull/115179/changes,

@cvxluo cvxluo merged commit 2cde52f into master May 29, 2026
66 checks passed
@cvxluo cvxluo deleted the cvxluo/drop-deprecated-snake-case-aliases-from-trace-meta branch May 29, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants