Skip to content

ref(msteams): Replace legacy configure view with the pipeline redirect#116520

Open
evanpurkhiser wants to merge 2 commits into
masterfrom
evanpurkhiser/ref-msteams-replace-legacy-configure-view-with-the-pipeline-redirect
Open

ref(msteams): Replace legacy configure view with the pipeline redirect#116520
evanpurkhiser wants to merge 2 commits into
masterfrom
evanpurkhiser/ref-msteams-replace-legacy-configure-view-with-the-pipeline-redirect

Conversation

@evanpurkhiser
Copy link
Copy Markdown
Member

Now that the API-driven pipeline is in place (#116490) and the frontend can drive the install modal (#116488), route /extensions/msteams/configure/ through a small RedirectView that forwards signed_params to /extensions/msteams/link/, where the modal takes over. The URL has to keep resolving because the Sentry-Teams bot card has it baked in as the install link.

  • Adds MsTeamsConfigureRedirectView and points the configure route at it.
  • Drops the legacy MsTeamsExtensionConfigurationView, the no-op MsTeamsPipelineView, and the legacy-flow tests. get_pipeline_views() now returns an empty list; the API step is the only setup path.
  • build_integration reads top-level pipeline state directly now that the legacy view (which bound state under state["msteams"]) is gone.

Fixes VDY-101: Microsoft Teams: API-driven integration setup

Now that the API-driven pipeline is in place and the frontend can drive the
install modal, route `/extensions/msteams/configure/` through a small
`RedirectView` that forwards `signed_params` to `/extensions/msteams/link/`,
where the modal takes over. The URL has to keep resolving because the
Sentry-Teams bot card has it baked in as the install link.

- Adds `MsTeamsConfigureRedirectView` and points the configure route at it.
- Drops the legacy `MsTeamsExtensionConfigurationView`, the no-op
  `MsTeamsPipelineView`, and the legacy-flow tests. `get_pipeline_views()`
  now returns an empty list; the API step is the only setup path.
- `build_integration` reads top-level pipeline state directly now that the
  legacy view (which bound state under `state["msteams"]`) is gone.

Fixes [VDY-101: Microsoft Teams: API-driven integration setup](https://linear.app/getsentry/issue/VDY-101/microsoft-teams-api-driven-integration-setup)
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner May 29, 2026 20:13
@evanpurkhiser evanpurkhiser requested review from Christinarlong and thetruecpaul and removed request for a team May 29, 2026 20:13
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 29, 2026

VDY-101

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 29, 2026
@getsantry getsantry Bot requested a review from a team as a code owner May 29, 2026 20:15
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.59%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants