ref(charts): Remove zoom optimizations #11669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There's an odd re-render bug when zooming because we're going from relative period to absolute (and we don't support previous period with absolute dates yet). This will be in fixed in a future PR. |
We tried to preserve echarts zoom as best we could but it will break dashboard widgets. Instead we re-render chart but dim the chart while its re-rendering
billyvg
force-pushed
the
ref/charts/remove-zoom-optimizations
branch
from
a7689e1 to
1be0056
Compare
This was referenced Jan 25, 2019
lynnagara
approved these changes
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to preserve echarts zoom as best we could but it will break dashboard widgets. Instead we re-render chart but dim the chart while its re-rendering