fix(ui): Use kB instead of KB for byte formatting - #118906
Open
obostjancic wants to merge 2 commits into
Open
Conversation
The base-10 byte formatters were emitting "KB" as the symbol for kilobyte. The correct SI symbol is "kB" (lowercase k for kilo); "KB" is not a valid unit. Update the formatters, their tests, docs, and user-facing copy accordingly. Base-2 units (KiB, etc.) are unchanged.
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-5xhgmfvyz.sentry.dev |
obostjancic
marked this pull request as ready for review
July 2, 2026 14:26
obostjancic
changed the title
obostjancic
marked this pull request as draft
July 2, 2026 14:27
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
volokluev
approved these changes
Jul 2, 2026
obostjancic
marked this pull request as ready for review
July 6, 2026 08:40
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Byte size formatting used
KBinstead ofkB. This changes all base-10 formatters to emitkB. Base-2 units (KiB, etc.) are already correct and untouched.Changed formatters:
formatBytesBase10,formatMetricUsingUnit, profilingunits.ts, and getsentry'sformatByteUnits/bigNumFormatter. Also updated related UI copy, docs, and specs.