feat(pr iteration): add nudge for updating github app permissisons#119111
Conversation
logic for commenting on autofix PRs during PR iteration when tool calls fail potentially due to out of date github app permissions logic for passing "warnings" back from group ai autofix GET endpoint specifically for failed tool calls potentially due to out of date github app permissions
like the slack integration we want to have nudges / buttons for the github integration so users can easily be notified that some installation is out of date, and so they can update it part of this is updating the serializer for integrations to pass an "out of date" field to let the frontend know that the integration needs to be updated based on logic that runs in the backend that has easy access to options not exposed through the API also moving around the slack scope class definition bc it was causing a circular import issue
we recently implemented nudges + buttons in the integration settings pages for updating the slack app if it was out of date and now we're doing the same for users' github app installations the implementation is pretty much the same except we have a different modal in this one since we're directing the user to a specific URL instead of having them go through the install flow again
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
alexsohn1126
left a comment
alexsohn1126
left a comment
There was a problem hiding this comment.
Seems good to me, thanks 🙏
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 608d8bb. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
2 participants
deps on #119082
We already have nudges for updating slack app permissions so we want to add nudges for the github app as well. This works differently from the slack app nudges since for the slack app to update the app you go through the install flow again, but in this case there's a dedicated URL for updating the github app and going through the install flow again will not work.
There's also a refactor in here regarding the deletion in the integration detailed page where it now uses
useMutationand this is so we can avoid a race condition when refetching since we changed the stale time for the config query on that page to 0.