fix(dashboards): Guard against undefined param.value in tooltip formatter - #119361
Open
sentry[bot] wants to merge 1 commit into
Open
fix(dashboards): Guard against undefined param.value in tooltip formatter#119361sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-3npz7as79.sentry.dev |
billyvg
reviewed
Jul 24, 2026
| // Filter null values from tooltip | ||
| // @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message | ||
| if (param.value[1] === null) { | ||
| if (!param.value || param.value[1] === null) { |
Member
There was a problem hiding this comment.
@sentry can you explicitly check for undefined instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses
TypeError: Cannot read properties of undefined (reading '1')occurring in the time series widget tooltip formatter.The root cause was identified as attempting to access
param.value[1]without first verifying thatparam.valueitself is defined. ECharts can supply tooltip parameters whereparam.valueisundefined(e.g., for scatter series or when data points are missing).This issue became more frequent following commit
5f97e07(PR #109881), which changed the X-axis type from"time"to"value"intimeSeriesWidgetVisualization.tsx. This change altered the structure of tooltip parameters, leading toparam.valuebeingundefinedin certain scenarios.The fix involves explicitly checking for
undefinedbefore attempting to access array properties. Specifically, line 265 instatic/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.tsxwas updated fromif (!param.value || param.value[1] === null)toif (param.value === undefined || param.value[1] === null).Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-3A41
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.