fix(issue-views): Stop view sort changes from overwriting the feed sort#119415
Merged
Conversation
Changing the sort inside a saved view wrote to the same localStorage key that determines the default sort on the issues feed, so the change unexpectedly followed users back to the feed. The stored sort also leaked the other way: on a view URL with page filter params but no sort param, it overrode the view's saved sort. Treat the stored sort as feed-only: view pages no longer read or write it and instead fall back to the view's saved querySort, matching how page filters already skip persistence on views. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
nora-shap
approved these changes
Jul 10, 2026
scttcper
approved these changes
Jul 10, 2026
roggenkemper
added a commit
that referenced
this pull request
Jul 13, 2026
… chosen (#119537) The new-feature badge on the sort dropdown trigger (shown behind `issue-stream-recommended-sort-default`) announcing the Recommended sort default showed whenever the current sort was Recommended, so a user who explicitly selected Recommended — or switched away and came back — kept seeing "Issues now default to the Recommended sort. Pick a different sort and we'll remember your choice." indefinitely. The trigger badge now shows only while no stored sort exists, i.e. while the user is seeing Recommended because of the default rather than by choice. Any explicit sort selection, including re-selecting Recommended, writes the stored sort and permanently dismisses it — no new state needed. It is also hidden on view pages, where sort changes are no longer remembered (#119415), so the tooltip copy would be wrong. The badge on the Recommended option inside the dropdown menu is unchanged and still always shows. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the sort inside a saved issue view wrote to the same localStorage key that provides the default sort for the issues feed, so a sort picked while in a view unexpectedly followed you back to the feed. The stored sort also leaked the other way: loading a view URL that has page filter params but no
sortparam skips query param hydration, so the feed's stored sort silently overrode the view's saved sort.The stored sort is now feed-only. View pages neither write it on sort change nor read it as a default — they fall back to the view's saved
querySortinstead. This mirrors how views already opt out of page filter persistence (disablePersistence/skipLoadLastUsedonPageFiltersContainer).