fix(analytics): Unify project platform selection in growth event - #120115
Merged
jaydgoss merged 1 commit intoJul 23, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
marked this pull request as ready for review
July 20, 2026 19:13
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 20, 2026 20:40
c2205d3 to
e2ebdac
Compare
jaydgoss
changed the title
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 20, 2026 20:59
8dd70c8 to
8170cf3
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 20, 2026 20:59
e2ebdac to
9489228
Compare
jaydgoss
marked this pull request as draft
July 20, 2026 21:24
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 20, 2026 21:26
8170cf3 to
2aa8cdf
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 20, 2026 21:26
9489228 to
68ea3ac
Compare
jaydgoss
marked this pull request as ready for review
July 20, 2026 21:34
ryan953
approved these changes
Jul 22, 2026
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 23, 2026 19:23
2aa8cdf to
93fd3be
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 23, 2026 19:23
68ea3ac to
eed58f7
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 23, 2026 20:41
93fd3be to
d6bc482
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 23, 2026 20:41
eed58f7 to
b4917b8
Compare
Contributor
Sentry Snapshot Testing
|
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 23, 2026 20:53
d6bc482 to
c42a1f0
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 23, 2026 20:53
b4917b8 to
f6ec26d
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 23, 2026 21:09
c42a1f0 to
6e6bf00
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 23, 2026 21:09
f6ec26d to
0e0cf01
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-core-wizard-variant
branch
from
July 23, 2026 22:28
6e6bf00 to
a62d7aa
Compare
Base automatically changed from
jaygoss/scm-project-creation-core-wizard-variant
to
master
July 23, 2026 23:10
Use growth.select_platform as the sole project-creation selection event for both variants. Preserve SCM detected versus manual attribution in selection_source while leaving SCM onboarding on its existing event. Refs VDY-133
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-growth-platform-parity
branch
from
July 23, 2026 23:11
0e0cf01 to
2806982
Compare
jaydgoss
added a commit
that referenced
this pull request
Jul 23, 2026
…ct creation (#120119) ## TLDR Adds the SCM manage-providers funnel event and makes messaging-integration installs segmentable by SCM versus legacy without mislabeling SCM onboarding as project creation. ## Details This PR is stacked on the platform-selection parity PR (#120115). `ScmIntegrationSelect` now fires `project_creation.manage_providers_clicked` with the project-creation SCM variant when its integration-settings footer is used. Messaging installs continue using one flow value plus `variant`. Legacy project creation passes the project-creation messaging view with `variant:'legacy'`. The SCM alert-frequency section now threads its existing `analyticsFlow` into `ScmIssueAlertNotificationOptions`: SCM project creation uses the project-creation messaging view, while SCM onboarding uses `view:'onboarding'`; both carry `variant:'scm'`. The shared alert-rule-creation caller remains on its existing view with no variant. The flow-aware mapping fixes the previous cross-flow leak where the shared SCM alert-frequency UI labeled onboarding messaging installs as project creation. End-to-end coverage opens the setup modal and starts an install from both SCM flows, asserting the emitted `view` and `variant`; the manage-providers click remains covered separately. Refs VDY-133
Christinarlong
pushed a commit
that referenced
this pull request
Jul 24, 2026
…0115) ## TLDR Uses `growth.select_platform` as the single project-creation platform-selection event for both legacy and SCM, distinguished by `variant` and by `selection_source: 'detected' | 'manual'`. ## Details Stacked on the core-wizard `variant` PR (#120080). Legacy `CreateProject` already selects through `<PlatformPicker>`, whose live `growth.select_platform` counter is the continuity anchor; keeping a second `project_creation.platform_selected` signal for SCM would permanently emit two events for one selection. Legacy now passes `source="project-creation"` and `variant="legacy"` into `<PlatformPicker>`. The picker stamps `selection_source:'manual'` on card clicks and continues threading source/variant into its selection, search, and category events. SCM platform commitments route through `trackScmPlatformSelected`. Its project-creation arm emits only `growth.select_platform` with `source:'project-creation'`, `variant:'scm'`, and the detected/manual selection source supplied by the caller. Its onboarding arm preserves `onboarding.scm_platform_selected` unchanged, so SCM onboarding does not enter the project-creation growth bucket. The obsolete `project_creation.platform_selected` registry entry is removed. The component coverage verifies that SCM project creation emits only the growth event with detected attribution, SCM onboarding keeps its prior event, and ordinary `<PlatformPicker>` selections report manual attribution. The broader project-install and SCM suites guard the shared call sites and framework modal routing. BI note: live SCM traffic moves from `project_creation.scm_platform_selected` into `growth.select_platform`; legacy `growth.select_platform.source` moves from undefined to `project-creation`. The existing Amplitude event name remains unchanged to preserve that counter. Refs VDY-133
Christinarlong
pushed a commit
that referenced
this pull request
Jul 24, 2026
…ct creation (#120119) ## TLDR Adds the SCM manage-providers funnel event and makes messaging-integration installs segmentable by SCM versus legacy without mislabeling SCM onboarding as project creation. ## Details This PR is stacked on the platform-selection parity PR (#120115). `ScmIntegrationSelect` now fires `project_creation.manage_providers_clicked` with the project-creation SCM variant when its integration-settings footer is used. Messaging installs continue using one flow value plus `variant`. Legacy project creation passes the project-creation messaging view with `variant:'legacy'`. The SCM alert-frequency section now threads its existing `analyticsFlow` into `ScmIssueAlertNotificationOptions`: SCM project creation uses the project-creation messaging view, while SCM onboarding uses `view:'onboarding'`; both carry `variant:'scm'`. The shared alert-rule-creation caller remains on its existing view with no variant. The flow-aware mapping fixes the previous cross-flow leak where the shared SCM alert-frequency UI labeled onboarding messaging installs as project creation. End-to-end coverage opens the setup modal and starts an install from both SCM flows, asserting the emitted `view` and `variant`; the manage-providers click remains covered separately. Refs VDY-133
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Uses
growth.select_platformas the single project-creation platform-selection event for both legacy and SCM, distinguished byvariantand byselection_source: 'detected' | 'manual'.Details
Stacked on the core-wizard
variantPR (#120080). LegacyCreateProjectalready selects through<PlatformPicker>, whose livegrowth.select_platformcounter is the continuity anchor; keeping a secondproject_creation.platform_selectedsignal for SCM would permanently emit two events for one selection.Legacy now passes
source="project-creation"andvariant="legacy"into<PlatformPicker>. The picker stampsselection_source:'manual'on card clicks and continues threading source/variant into its selection, search, and category events.SCM platform commitments route through
trackScmPlatformSelected. Its project-creation arm emits onlygrowth.select_platformwithsource:'project-creation',variant:'scm', and the detected/manual selection source supplied by the caller. Its onboarding arm preservesonboarding.scm_platform_selectedunchanged, so SCM onboarding does not enter the project-creation growth bucket. The obsoleteproject_creation.platform_selectedregistry entry is removed.The component coverage verifies that SCM project creation emits only the growth event with detected attribution, SCM onboarding keeps its prior event, and ordinary
<PlatformPicker>selections report manual attribution. The broader project-install and SCM suites guard the shared call sites and framework modal routing.BI note: live SCM traffic moves from
project_creation.scm_platform_selectedintogrowth.select_platform; legacygrowth.select_platform.sourcemoves from undefined toproject-creation. The existing Amplitude event name remains unchanged to preserve that counter.Refs VDY-133