fix(seer): Show loading state instead of empty agent dropdown on initial load - #120221
Open
billyvg wants to merge 2 commits into
Open
fix(seer): Show loading state instead of empty agent dropdown on initial load#120221billyvg wants to merge 2 commits into
billyvg wants to merge 2 commits into
Conversation
…ial load SeerProjectTable's per-row agent Select rendered with a real value but an empty options list until the agentSelectOptions query resolved, causing the dropdown to appear blank and then pop in. Gate the cell (and the bulk header dropdown) on that query's pending state instead, mirroring the existing fix in AutofixAgent. Fixes CW-1529
github-actions
Bot
added
the
Scope: Frontend
Keep field.Select rendered during the agentSelectOptions race window instead of swapping the cell for a LoadingIndicator. Disable the select and fall back to a single placeholder option keyed to the current value, so Select's value-matching always resolves and the field never renders blank. Also add an aria-label since the select had none, which the updated tests rely on to query it.
Member
Author
|
@sentry review |
billyvg
marked this pull request as ready for review
July 21, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectinSeerProjectTablerenders with a realvalue(e.g.'seer') but an emptyoptionslist until the separateagentSelectOptionsquery resolves, so the dropdown briefly appears blank before the correct option pops in.AutofixAgent.PreferredAgentDropdownMenu(disabled + busy trigger while pending).Fixes CW-1529.
Test plan
seerProjectTable.spec.tsxtests asserting a loading indicator (not an empty select) shows while options are pending, and the realSeervalue appears once they resolvepnpm test-ci static/app/components/seer/projectTable/seerProjectTable.spec.tsxpasses (5/5)pnpm run typecheckclean for touched files