fix(analytics): Preserve setup-docs project attribution - #120229
Merged
jaydgoss merged 1 commit intoJul 24, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
marked this pull request as ready for review
July 21, 2026 17:47
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-platform-analytics-completeness
branch
from
July 21, 2026 17:53
0324dd4 to
d0a5c6b
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 21, 2026 17:57
2704d0d to
c73a1a8
Compare
jaydgoss
changed the base branch from
jaygoss/scm-project-creation-platform-analytics-completeness
to
jaygoss/scm-project-creation-framework-action-variants
July 21, 2026 17:57
jaydgoss
marked this pull request as draft
July 21, 2026 18:01
jaydgoss
marked this pull request as ready for review
July 21, 2026 18:06
Member
|
@sentry review |
bruno-garcia
approved these changes
Jul 22, 2026
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-action-variants
branch
from
July 23, 2026 19:24
1f03a96 to
fa84769
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 19:24
c73a1a8 to
f2ad681
Compare
Contributor
Sentry Snapshot Testing
|
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-action-variants
branch
from
July 23, 2026 20:42
fa84769 to
8144860
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 20:42
f2ad681 to
249d4a0
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-action-variants
branch
from
July 23, 2026 20:54
8144860 to
1004f0d
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 20:54
249d4a0 to
8f6b657
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-action-variants
branch
from
July 23, 2026 21:09
1004f0d to
1a51c2b
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 21:09
8f6b657 to
d8324d5
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-action-variants
branch
from
July 24, 2026 01:41
1a51c2b to
7a152c6
Compare
Base automatically changed from
jaygoss/scm-project-creation-framework-action-variants
to
master
July 24, 2026 01:52
Add project_id to project-creation DSN copy events while preserving onboarding payloads. Report the platform ID instead of the project slug in getting-started removal events. Refs VDY-133
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 24, 2026 01:53
d8324d5 to
5b14077
Compare
Christinarlong
pushed a commit
that referenced
this pull request
Jul 24, 2026
## TLDR Project-creation setup-docs events now retain the project and platform identifiers BI needs to join downstream activity to the project that was created. ## Details The project-creation BI audit found two payload-shape gaps after the getting-started handoff. `project_creation.dsn_copied` carried platform and variant but not `project_id`, while the getting-started removal events populated their `platform` field with the project slug. A small `docsFlowProjectIdParams` helper now adds `project_id` to DSN-copy events for the project-creation and unmarked project surfaces. The onboarding and SCM-onboarding arms keep their existing payload shape, matching the established rule that their distinct event names remain unchanged. `PlatformDocHeader` now reports `platform.id` for data-removal confirmation and completion instead of `recentCreatedProject.slug`. The callback dependency and regression expectations move with that value so the event contract consistently identifies the SDK platform rather than the project. Focused coverage locks the four docs-flow project-ID cases, the unmarked fallback, both onboarding exclusions, and the corrected platform payload for marked and unmarked getting-started views. Refs VDY-133
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Project-creation setup-docs events now retain the project and platform identifiers BI needs to join downstream activity to the project that was created.
Details
The project-creation BI audit found two payload-shape gaps after the getting-started handoff.
project_creation.dsn_copiedcarried platform and variant but notproject_id, while the getting-started removal events populated theirplatformfield with the project slug.A small
docsFlowProjectIdParamshelper now addsproject_idto DSN-copy events for the project-creation and unmarked project surfaces. The onboarding and SCM-onboarding arms keep their existing payload shape, matching the established rule that their distinct event names remain unchanged.PlatformDocHeadernow reportsplatform.idfor data-removal confirmation and completion instead ofrecentCreatedProject.slug. The callback dependency and regression expectations move with that value so the event contract consistently identifies the SDK platform rather than the project.Focused coverage locks the four docs-flow project-ID cases, the unmarked fallback, both onboarding exclusions, and the corrected platform payload for marked and unmarked getting-started views.
Refs VDY-133