Skip to content

feat(action log): Use GALE in GroupActivitiesEndpoint - #120282

Merged
ceorourke merged 7 commits into
masterfrom
ceorourke/gale-on-group-activities
Jul 23, 2026
Merged

feat(action log): Use GALE in GroupActivitiesEndpoint#120282
ceorourke merged 7 commits into
masterfrom
ceorourke/gale-on-group-activities

Conversation

@ceorourke

Copy link
Copy Markdown
Member

Now that we have the GroupActionLogEntrySerializer we can use it in the remaining endpoints that serialize Activity and swap in GroupActionLogEntries. This PR swaps it in for the GroupActivitiesEndpoint.

@ceorourke
ceorourke requested review from a team as code owners July 21, 2026 22:38
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 21, 2026
Comment thread src/sentry/issues/endpoints/group_activities.py
Comment thread src/sentry/issues/endpoints/group_activities.py Outdated
Comment thread src/sentry/issues/endpoints/group_activities.py Outdated
Comment thread src/sentry/issues/endpoints/group_activities.py Outdated
{
"activity": serialized,
}
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale or deleted comments in GALE feed

Medium Severity

When projects:issue-action-log-read-from-gale is on, this endpoint returns raw GALE rows as the activity feed. GALE is append-only: comment edits add COMMENT_EDIT without updating the original COMMENT text, and deletes add COMMENT_DELETE without removing the original. Unlike Activity, which updates notes in place and drops deleted ones, clients can see outdated comment text and comments that were already deleted.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7557b1f. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's fine, I'm dealing with that in #120288 doesn't really affect this one which is just reading

@ceorourke
ceorourke force-pushed the ceorourke/gale-on-group-activities branch from 7557b1f to 7848079 Compare July 22, 2026 19:11
Comment thread tests/sentry/issues/endpoints/test_group_details.py Outdated
Comment thread src/sentry/issues/endpoints/group_details.py Outdated
@ceorourke
ceorourke requested a review from kcons July 22, 2026 19:13
Comment thread tests/sentry/issues/endpoints/test_group_details.py Outdated
@ceorourke
ceorourke force-pushed the ceorourke/gale-on-group-activities branch from 0f31c42 to 9922831 Compare July 22, 2026 20:17

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9922831. Configure here.

Comment thread tests/sentry/issues/endpoints/test_group_activities.py Outdated
Comment thread tests/sentry/issues/endpoints/test_group_activities.py Outdated
@ceorourke
ceorourke merged commit ef994b0 into master Jul 23, 2026
66 checks passed
@ceorourke
ceorourke deleted the ceorourke/gale-on-group-activities branch July 23, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants