fix(integrations): Record GitLab webhook Http404 as halt, not error#120320
Open
sentry[bot] wants to merge 2 commits into
Open
fix(integrations): Record GitLab webhook Http404 as halt, not error#120320sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial attempt to fix this involved adding a blanket
Http404exemption toIntegrationEventLifecycle.__exit__. However, this was identified as problematic, as other integration flows (e.g., identity linking) also re-raiseIntegrityErrorasHttp404, and silencing these would mask genuine application errors.This revised fix addresses the issue by:
Http404handling fromIntegrationEventLifecycle.__exit__insrc/sentry/integrations/utils/metrics.py.try/except Http404block around theevent_handlercall within the GitLab webhook dispatch loop insrc/sentry/integrations/gitlab/webhooks.py. When anHttp404is caught in this specific context,lifecycle.record_halt(e)is explicitly called before re-raising the exception.This ensures that expected
Http404s originating specifically from GitLab webhooks are correctly recorded ashaltevents (preventing Sentry error issues), while maintaining proper error reporting forHttp404s that might indicate genuine problems in other integration contexts.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-43KZ
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.