Skip to content

fix(trace): Stabilize trace shell during initial loading#120331

Open
nsdeschenes wants to merge 5 commits into
masterfrom
nd/EXP-1112/stabilize-trace-shell
Open

fix(trace): Stabilize trace shell during initial loading#120331
nsdeschenes wants to merge 5 commits into
masterfrom
nd/EXP-1112/stabilize-trace-shell

Conversation

@nsdeschenes

Copy link
Copy Markdown
Contributor

Keep the trace page mounted while initial metadata and tree data resolve, preventing the empty-project state from briefly replacing the Waterfall. Project avatars also remain anchored to the right when optional header details arrive.

This is the first PR in the EXP-1112 stack and has no dependency on the later data-loading changes.

@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

EXP-1112

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 22, 2026
Comment thread static/app/views/performance/newTraceDetails/index.tsx Outdated
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/stabilize-trace-shell branch from f28c5c1 to 2f65f55 Compare July 22, 2026 15:03
@nsdeschenes
nsdeschenes marked this pull request as ready for review July 22, 2026 15:36
@nsdeschenes
nsdeschenes requested a review from a team as a code owner July 22, 2026 15:36
Comment thread static/app/views/performance/newTraceDetails/index.tsx Outdated
Keep the no-project boundary mounted while initial trace data settles. Passing loading state through the boundary avoids remounting an already-rendered waterfall when metadata resolves.
Give the project container explicit right alignment so late-arriving environment and runtime highlights do not shift the avatars across the header.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 498424e. Configure here.

Comment thread static/app/views/performance/newTraceDetails/index.tsx Outdated

@DominikB2014 DominikB2014 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants