Skip to content

fix(trace): Stabilize asynchronous overview loading#120334

Open
nsdeschenes wants to merge 5 commits into
nd/EXP-1112/resolve-trace-overviewfrom
nd/EXP-1112/stabilize-trace-overview-loading
Open

fix(trace): Stabilize asynchronous overview loading#120334
nsdeschenes wants to merge 5 commits into
nd/EXP-1112/resolve-trace-overviewfrom
nd/EXP-1112/stabilize-trace-overview-loading

Conversation

@nsdeschenes

Copy link
Copy Markdown
Contributor

Keep the trace header and tab navigation stable while optional overview data resolves. Direct links to Logs and Application Metrics remain selected during loading, unavailable selections fall back synchronously, and representative details use localized placeholders instead of replacing the full trace chrome.

This is PR 4 of the EXP-1112 stack and is based on nd/EXP-1112/resolve-trace-overview. The final PR adds multi-project context for telemetry-only traces.

@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

EXP-1112

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 22, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6bcfbd6. Configure here.

Comment thread static/app/views/performance/newTraceDetails/useTraceLayoutTabs.tsx
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/resolve-trace-overview branch from be58085 to 13d1da6 Compare July 22, 2026 14:19
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/stabilize-trace-overview-loading branch from 6bcfbd6 to dfc5ba1 Compare July 22, 2026 14:19
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/resolve-trace-overview branch from 13d1da6 to 5ac4b1d Compare July 22, 2026 15:03
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/stabilize-trace-overview-loading branch from dfc5ba1 to acf2d82 Compare July 22, 2026 15:03
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/stabilize-trace-overview-loading branch from acf2d82 to a0c42e1 Compare July 22, 2026 15:25
@nsdeschenes
nsdeschenes marked this pull request as ready for review July 22, 2026 15:36
@nsdeschenes
nsdeschenes requested a review from a team as a code owner July 22, 2026 15:36
Render resolved header metadata and tab navigation without waiting for optional root-item details. Keep unresolved representative data localized to stable placeholders.

Fixes EXP-1112
Keep the requested Logs or Application Metrics tab in the rendered options while legacy availability queries resolve, so the controlled tab always has a matching item.

Refs EXP-1112
Expose the newly resolved Logs or Application Metrics tab synchronously when the stored selection is no longer available, preventing an intermediate Waterfall render.

Refs EXP-1112
Keep representative header placeholders active while legacy log availability resolves. Avoid mounting a trace-wide logs provider for waterfall drawers that do not consume it.

Refs EXP-1112
Keep unverified Logs and Metrics tabs out of the default tab list while preserving direct links when overview availability cannot be determined.

Refs EXP-1112
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/resolve-trace-overview branch from f60cdef to ce0a86a Compare July 22, 2026 16:54
@nsdeschenes
nsdeschenes force-pushed the nd/EXP-1112/stabilize-trace-overview-loading branch from a0c42e1 to 09a51d2 Compare July 22, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant