fix(trace): Remove eventTransaction in showJSONLink check - #120477
Conversation
github-actions
Bot
added
the
Scope: Frontend
2961cac to
4aba171
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4aba171. Configure here.
| /> | ||
| </Tooltip> | ||
| {props.showJSONLink && transactionId ? ( | ||
| {props.showJSONLink && (canShowEAPSpanJSON || transactionId) ? ( |
There was a problem hiding this comment.
Based on your description, will we have to eventually get rid of transactionId? If so, might be worth leaving a todo comment or smth similar
There was a problem hiding this comment.
Transaction IDs actually keep existing, even though transaction events are going away 😓 We still group spans into segments, which approximate transactions, and the user-facing name for them is still (for the moment) transactions.
Either way, this particular use of transactionId will go away when the non-EAP path is removed, which is hopefully happening in the next week or two. It'll show up as dead code so I'm not too worried about the todo. Good suggestion though!
I'm gradually removing all references to `eventTransaction` from the EAP span version of the trace waterfall and span drawer (see BROWSE-646). This PR removes it from the `showJSONLink` gate on `TraceDrawerComponents.NodeActions` - it actually works fine downstream already without a transaction, just had to make the `transactionId` check only affect the branch that uses the old transaction JSON URL.
2 participants
I'm gradually removing all references to
eventTransactionfrom the EAP span version of the trace waterfall and span drawer (see BROWSE-646).This PR removes it from the
showJSONLinkgate onTraceDrawerComponents.NodeActions- it actually works fine downstream already without a transaction, just had to make thetransactionIdcheck only affect the branch that uses the old transaction JSON URL.