fix(preprod): Align snapshot comment approval status - #120503
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
@sentry review |
jamieQ
force-pushed
the
fix/eme-1249-snapshot-approval-mismatch
branch
from
July 23, 2026 19:46
130c0a0 to
6711040
Compare
Separate PR comment reporting criteria from the effective snapshot approval policy so comments only request approval when status checks require it. Refs EME-1249
jamieQ
force-pushed
the
fix/eme-1249-snapshot-approval-mismatch
branch
from
July 23, 2026 20:46
6711040 to
ab3b9d4
Compare
jamieQ
marked this pull request as ready for review
July 23, 2026 21:04
NicoHinderling
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot PR comments now derive approval requirements from the same effective policy as the snapshot status check. A reportable change only displays Needs approval when status checks are enabled and that change category is configured to fail; otherwise the comment displays Changes detected.
This keeps PR-comment reporting preferences independent from approval policy while sharing the underlying change evaluator. It also covers disabled status checks and differing reporting/approval criteria with behavioral tests.
Refs EME-1249