test(project-install): Stabilize notification refetch test - #120539
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
marked this pull request as ready for review
July 24, 2026 00:06
jaydgoss
marked this pull request as draft
July 24, 2026 00:07
jaydgoss
marked this pull request as ready for review
July 24, 2026 00:39
jaydgoss
force-pushed
the
test/vdy-78-scm-project-creation-unit-coverage
branch
from
July 24, 2026 02:23
72fe0e6 to
1bda545
Compare
jaydgoss
force-pushed
the
test/vdy-78-scm-project-creation-unit-coverage
branch
from
July 24, 2026 02:32
1bda545 to
07ea7bc
Compare
Base automatically changed from
test/vdy-78-scm-project-creation-unit-coverage
to
master
July 24, 2026 02:44
jaydgoss
force-pushed
the
test/project-install-notification-refetch-flake
branch
from
July 24, 2026 02:45
1713f01 to
058c453
Compare
ryan953
approved these changes
Jul 24, 2026
scttcper
approved these changes
Jul 24, 2026
Christinarlong
pushed a commit
that referenced
this pull request
Jul 24, 2026
## TLDR Stabilizes persisted notification-selection refetch coverage by waiting for the hook's initial setup state before triggering the focus refetch. ## Details The test previously waited only for React Query's success flag and then synchronously asserted state set by a later effect, so slower CI runs could observe `shouldRenderSetupButton` before that effect committed. It now treats the setup button as the observable initial-state boundary, then preserves the existing assertions that the focus refetch restores the persisted provider, integration, channel, and action without changing production behavior.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Stabilizes persisted notification-selection refetch coverage by waiting for the hook's initial setup state before triggering the focus refetch.
Details
The test previously waited only for React Query's success flag and then synchronously asserted state set by a later effect, so slower CI runs could observe
shouldRenderSetupButtonbefore that effect committed. It now treats the setup button as the observable initial-state boundary, then preserves the existing assertions that the focus refetch restores the persisted provider, integration, channel, and action without changing production behavior.