ref(nav): Clean up leftover page-frame naming - #120557
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
priscilawebdev
force-pushed
the
ref/cleanup-pageframe-naming
branch
from
July 24, 2026 12:23
fae3b80 to
7ad9bba
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7ad9bba. Configure here.
priscilawebdev
marked this pull request as ready for review
July 24, 2026 12:29
priscilawebdev
force-pushed
the
ref/cleanup-pageframe-naming
branch
from
July 24, 2026 12:34
7ad9bba to
4643b6d
Compare
The page-frame feature flag has shipped and been removed, so drop the now-meaningless page-frame qualifier from identifiers left behind by the migration. Pure rename, no behavior change. - isMobilePageFrame -> isMobile (nav primary/secondary) - DesktopPageFrameNavigationLink -> DesktopNavigationLink - PageFrameSidebarNavigationLink -> SidebarNavigationLink - StyledPageFrameReorderableLink -> StyledReorderableLink - PageFrameViewTitleWrapper -> ViewTitleWrapper - pageFrameContent / pageFrameBreadcrumb locals - NAVIGATION_MOBILE_TOPBAR_HEIGHT_WITH_PAGE_FRAME -> NAVIGATION_MOBILE_CONTENT_HEIGHT (48px mobile content top bar); the 40px NAVIGATION_MOBILE_TOPBAR_HEIGHT is left unchanged - Fix stale comments referencing MobilePageFrameNavigation (now MobileNavigation)
priscilawebdev
force-pushed
the
ref/cleanup-pageframe-naming
branch
from
July 24, 2026 12:37
4643b6d to
70fad46
Compare
ryan953
approved these changes
Jul 24, 2026
natemoo-re
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure naming cleanup. The
page-framefeature flag has already shipped and been removed, but a number of identifiers still carry the now-meaninglesspage-framequalifier left behind by the migration. This drops that terminology. No behavior change.