chore(crons): When deleting checkins, skip marking them as pending deletion. - #120670
Merged
Conversation
…letion. We often delete a lot of checkins in a short period of time when deleting monitors (whether directly, via deleting a project or an org). This doubles the number of mutations we perform when deleting a cron, and there's no real need to do it in this case. Ideally we'd also throttle these, but this is a simple way to cut the load of deletions by half.
github-actions
Bot
added
the
Scope: Backend
klochek
approved these changes
Jul 27, 2026
wedamija
added a commit
that referenced
this pull request
Jul 27, 2026
We sometimes see large spikes in deletions from crons, which cause cpu spikes and pages. We don't need to delete these at full speed, so throttle how quickly we delete them. The downside of this method is that we'll keep the task hanging for longer. It's a simpler approach though that rewriting the deletions abstraction to be able to stop/start mid way through a whole delete, and should solve our problem. Related to #120670. We removed updates from the deletions process here, which should also significantly improve load. <!-- Describe your PR here. -->
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We often delete a lot of checkins in a short period of time when deleting monitors (whether directly, via deleting a project or an org). Before deletions, we mark all the rows as deletion in progress. This doubles the number of mutations we perform when deleting a cron, and there's no real need to do it in this case.
Ideally we'd also throttle these, but this is a simple way to cut the load of deletions by half.