chore(ACI): Remove workflow engine UI flag on the backend - #120712
Open
ceorourke wants to merge 2 commits into
Open
chore(ACI): Remove workflow engine UI flag on the backend#120712ceorourke wants to merge 2 commits into
ceorourke wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
ceorourke
force-pushed
the
ceorourke/remove-workflow-engine-ui-flag-backend
branch
from
July 28, 2026 16:56
2f07fb3 to
086ea76
Compare
ceorourke
force-pushed
the
ceorourke/remove-workflow-engine-ui-flag-backend
branch
from
July 28, 2026 18:09
086ea76 to
80b4a7b
Compare
ceorourke
commented
Jul 28, 2026
| context["snooze_alert"] = False | ||
| context["snooze_alert_urls"] = {} | ||
| context["snooze_alert"] = False | ||
| context["snooze_alert_urls"] = {} |
Member
Author
There was a problem hiding this comment.
maybe we don't even need this going forward since there is no snoozing?
Contributor
There was a problem hiding this comment.
yeah! I think we'll be able to start removing this stuff. 🎉
ceorourke
marked this pull request as ready for review
July 28, 2026 18:42
saponifi3d
approved these changes
Jul 28, 2026
saponifi3d
left a comment
saponifi3d
left a comment
Contributor
There was a problem hiding this comment.
lgtm once the tests are green 🎉
| context["snooze_alert"] = False | ||
| context["snooze_alert_urls"] = {} | ||
| context["snooze_alert"] = False | ||
| context["snooze_alert_urls"] = {} |
Contributor
There was a problem hiding this comment.
yeah! I think we'll be able to start removing this stuff. 🎉
|
|
||
| @mock_notify | ||
| @mock.patch("sentry.notifications.notifications.rules.logger") | ||
| @with_feature("organizations:workflow-engine-ui") # snooze |
Contributor
There was a problem hiding this comment.
is this the only test we had for workflow_engine + email? if so, instead of removing it, should we update the test to only use the workflow models / calls to ensure the email is sent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've fully GA'd (we had 2 customers opted out) the ACI UI flag we can remove the old code. This PR removes the remaining backend references to the flag which is mostly just for snoozing rules.