fix(discover): Avoid sorting field option inputs in place - #120724
Draft
scttcper wants to merge 2 commits into
Draft
fix(discover): Avoid sorting field option inputs in place#120724scttcper wants to merge 2 commits into
scttcper wants to merge 2 commits into
Conversation
generateFieldOptions sorted four arrays owned by its callers. Use copied sorting for each input and add coverage that their order stays untouched. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Make the ownership contract explicit in the function signature instead of relying on a regression test. Co-Authored-By: Codex <noreply@openai.com>
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateFieldOptions sorted four arrays owned by its callers.
Use copied sorting for each input and mark the arrays readonly so the ownership contract is enforced by the types.