perf(search): Avoid idle query builder work - #120725
Draft
scttcper wants to merge 4 commits into
Draft
Conversation
Don't build the listbox while the combobox is closed, avoid duplicate recent search subscriptions, and skip the empty filter registry query when it isn't used. Also move recent searches onto apiOptions and keep overlay options stable. The query builder suite is about 5% faster. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Bring the CI fixes from #120714 into the stacked performance branch. Co-Authored-By: Codex <noreply@openai.com>
knip correctly flags this since the options helper only supports the hook in the same file. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops building listbox contents while the combobox is closed, drops the duplicate recent search subscription, and skips the empty filter registry query. Also moves recent searches to apiOptions and keeps the Popper inputs stable.
about 5% faster, stacked on #120714