fix(projects): Projects endpoint should use spans - #120743
Merged
k-fish merged 1 commit intoJul 28, 2026
Merged
Conversation
The stats for the project list page was still going through metricsEnhanced for txn count etc, and had no option to use spans. This PR gives the endpoint it's own spans query — `is_transaction:true` grouped by `project.id` and ignores `dataset` for it (we'll delete it in the frontend). Spans return had to be zerofilled to match existing behaviour.
github-actions
Bot
added
the
Scope: Backend
narsaynorath
approved these changes
Jul 28, 2026
k-fish
enabled auto-merge (squash)
July 28, 2026 15:05
k-fish
deleted the
fix/project/stats-allows-spans-in-lieu-of-transactions
branch
July 28, 2026 15:14
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stats for the project list page was still going through metricsEnhanced for txn count etc, and had no option to use spans. We're no longer writing transaction information to
generic_metrics(where metricsEnhanced got the metrics from) so this needs to be switched over.This PR gives the endpoint it's own spans query;
is_transaction:truegrouped byproject.idand ignoresdatasetfor it (we'll delete it in the frontend). Spans return had to be zerofilled to match existing behaviour, and returned empty projects since this is an exhaustive listing.