ref(tables): move GridEditable and the explore tables onto the shared shell - #121179
Open
JoshuaKGoldberg wants to merge 1 commit into
Open
ref(tables): move GridEditable and the explore tables onto the shared shell#121179JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-22cl7acun.sentry.dev |
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
JoshuaKGoldberg
changed the title
… shell GridEditable and the explore table kit were two halves of one component: the kit imported `Grid`, `GridBody`, `GridHeadCell` and friends straight out of `gridEditable/styles`, so the de-facto shell was shared but the geometry, resize drag and column-track model were not. Points both at `core/table`: - `useTableStyles` is deleted; its callers go through the shell - the second resize drag loop and second track builder are gone - `GridEditableEmptyData`/`Error`/`Loading` collapse into the shell's status cell - `useVirtualRows` centralizes the virtualizer, which now spaces rows with padding rather than absolute offsets so rows stay in flow for subgrid GridEditable's public API is unchanged, so its 61 importers are untouched. Ref DE-1392 Ref DE-1405
JoshuaKGoldberg
force-pushed
the
de-1392-04-grid-family
branch
from
August 4, 2026 16:37
72b99ae to
841cb42
Compare
JoshuaKGoldberg
marked this pull request as ready for review
August 4, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #121178 -> #121177 -> #121176.
GridEditableand the explore table kit were two halves of one component:explore/components/tableimportedGrid,GridBody,GridHeadCelland friends straight out ofgridEditable/stylesand re-exported them under aliases. This points both atcore/table:useTableStylesis deleted; its callers go through the shellGridEditableEmptyData/Error/Loadingcollapse into the shell's status celluseVirtualRowscentralizes the virtualizer, which now spaces rows with padding rather than absolute offsets, so rows stay in flow for subgridInterestingly,
GridEditable's public API is unchanged. It's just the internals that use the shared table stuff now.Split out of #120745, as part of DE-1392 & DE-1405. See that PR for the full end state.