feat(api): Publish typed issue view creation endpoint - #123079
Merged
Conversation
cvxluo
marked this pull request as ready for review
August 28, 2026 22:41
Member
|
This reminded me that I never merged #122950, just merged it now. Could you rebase on this so we can verify that this won't break master? |
wedamija
approved these changes
Aug 28, 2026
cvxluo
force-pushed
the
cvxluo/publish-typed-issue-view-creation-endpoint
branch
from
August 31, 2026 15:47
5908584 to
7d99361
Compare
| "timeFilters": {"period": "14d"}, | ||
| } | ||
|
|
||
| response = self.client.post(self.url, data) |
Contributor
There was a problem hiding this comment.
Bug: The POST request in test_post() is missing content_type="application/json", causing the test client to send data as multipart/form-data, which fails to serialize nested objects and empty lists.
Severity: LOW
Suggested Fix
Add content_type="application/json" to the self.client.post() call to ensure the payload is correctly serialized as JSON. For example: self.client.post(self.url, data, content_type="application/json").
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: tests/apidocs/endpoints/events/test_organization_issue_views.py#L23
Potential issue: The test `test_post()` sends a POST request with a payload containing a
nested dictionary (`timeFilters`) and empty lists. Because
`content_type="application/json"` is not specified, the Django test client defaults to
`multipart/form-data`. This encoding does not correctly serialize the nested data
structures. The backend's `GroupSearchViewPostValidator` serializer will fail to
validate the malformed data, returning a 400 status code. This causes the test to fail
on the `self.validate_schema` call, which asserts that the response status code must be
in the 2xx range.
wedamija
approved these changes
Aug 31, 2026
Publish the issue view creation endpoint. Cover it in the agent-token public API matrix with the required feature flag and payload. Refs IS-15 Co-authored-by: Codex <noreply@openai.com>
cvxluo
force-pushed
the
cvxluo/publish-typed-issue-view-creation-endpoint
branch
from
August 31, 2026 17:33
7d99361 to
6ab8e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish the issue view creation endpoint. Redux of #122537
Cover it in the agent-token public API matrix with the required feature flag and payload.
Refs IS-15